Add compiler option to control code formatting#513
Closed
ZacSweers wants to merge 2 commits intogoogle:masterfrom
Closed
Add compiler option to control code formatting#513ZacSweers wants to merge 2 commits intogoogle:masterfrom
ZacSweers wants to merge 2 commits intogoogle:masterfrom
Conversation
This keeps the current formatting behavior by default, while allowing developers to opt out if they want via flag. Was going to open an issue but figured it would be better to just propose it as a PR. Disabling has two main uses in my experience: - The formatting step can actually be a significant chunk of compile time, and for those that don't need/want it gives them an option to disable it. - For us, the formatting actually causes build flakiness due to a JDK bug. We've currently been operating off of a fork that disables this entirely, but it would be nice to just point to upstream. I couldn't find where CompilerOptions are tested, if anywhere. Let me know if there's somewhere I should add tests
ZacSweers
changed the title
ronshapiro
changed the title
Author
|
Forgot this still existed |
Author
|
This is done in 6814a21 now, for those wondering |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps the current formatting behavior by default, while allowing developers to opt out if they want via flag. Was going to open an issue but figured it would be better to just propose it as a PR.
Disabling has two main uses in my experience:
I couldn't find where
CompilerOptionsare tested, if anywhere. Let me know if there's somewhere I should add tests.Edit: Resolves #515, resolves #457 and can help mitigate #368